[Kde-games-devel] Review Request: Increase the Row Height of Kiriki

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6931/#review10759
-----------------------------------------------------------


About the font sizing. It's not exactly what i'd like. Problem is you have decided 10 to be the "default" font which I'm sure it is not for some people.
So we have two options here.
First: Set the default value of the configuration option to -1, meaning the font doesn't need to be changed. This will probably mean you have to write some custom code for the configuration dialog since you don't want the -1 to show in the spinbox
Second: Have a different configuration value that stores a bool that defines if the custom font size is to be used or not. This might translate directly into a checkbox in the configuration dialog that enables/disables the spinbox

What do you think?



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://svn.reviewboard.kde.org/r/6931/#comment13297>

    I'd prefer if redraw had no parameters and the index stuff was done inside the redraw function itself


- Albert Astals Cid


On April 6, 2012, 2:32 p.m., Arjun Basu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6931/
> -----------------------------------------------------------
> 
> (Updated April 6, 2012, 2:32 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This is in response to the feature request https://bugs.kde.org/show_bug.cgi?id=225582. Now, there is a provision of increasing the font size and as a result the row height increases too. The value of the font size in the preferences can take values from 0 to 10. O being the default font size.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/configPage.ui 1282954 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1282954 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.kcfg 1282954 
>   /trunk/KDE/kdegames/kiriki/src/row.h 1282954 
>   /trunk/KDE/kdegames/kiriki/src/scores.h 1282954 
>   /trunk/KDE/kdegames/kiriki/src/scores.cpp 1282954 
> 
> Diff: http://svn.reviewboard.kde.org/r/6931/diff/
> 
> 
> Testing
> -------
> 
> I have tested it and it works fine
> 
> 
> Screenshots
> -----------
> 
> The New Preferences Dialog
>   http://svn.reviewboard.kde.org/r/6931/s/629/
> The Game Canvas after increasing font size
>   http://svn.reviewboard.kde.org/r/6931/s/630/
> 
> 
> Thanks,
> 
> Arjun Basu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120406/0fb4326a/attachment-0001.html>