[Kde-games-devel] Review Request: Konquest: Implement standing orders

[Pierre Ducroquet]

> On Oct. 21, 2011, 3:59 p.m., Jeffrey Kelling wrote:
> > It would be nice to have this feature in 4.8, so is anyone opposed to me committing it before the soft feature freeze (especially Pierre) ?
> > 
> > I guess it would be nice to be able to change the number of ships of an existing standing order, but this would require some major changes around the initialisation of the fleet dialogue (the dialogue would have to get write access to the players ship list) and I do not know if Pierre would be ok with this.
> > 
> > Apart from this would implement a feature requested in 2004, with no regressions.
> > 
> > Regards,
> > 
> > Jeffrey

I'm ok with commiting this.
As many may have noticed, I've been short on free-time in the last weeks… So better merge it asap, and if there is any non-spotted bug, fix it during the beta releases…


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6805/#review10443
-----------------------------------------------------------


On Sept. 18, 2011, 7:19 p.m., Jeffrey Kelling wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6805/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2011, 7:19 p.m.)
> 
> 
> Review request for KDE Games and Pierre Ducroquet.
> 
> 
> Description
> -------
> 
> This patch implements standing orders, i.e. orders that are repeated each turn if possible. Standing orders are issued the same way as normal order, additionally the added check box has to be checked. They are also removed the same way as normal orders (in the fleet overview). The orders are executed at the end of turn if enough ships are available, if not a message is issued. If the Planet is no longer under the players control the order is deleted. 
> 
> The number of ships that will be send due to standing order from a planet is displayed in that planets planet info (to its owner only).
> 
> 
> This addresses bug 87882.
>     https://bugs.kde.org/show_bug.cgi?id=87882
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/konquest/dialogs/fleetdlg.h 1254115 
>   trunk/KDE/kdegames/konquest/dialogs/fleetdlg.cc 1254115 
>   trunk/KDE/kdegames/konquest/game.h 1254115 
>   trunk/KDE/kdegames/konquest/game.cpp 1254115 
>   trunk/KDE/kdegames/konquest/gameview.h 1254115 
>   trunk/KDE/kdegames/konquest/gameview.cc 1254115 
>   trunk/KDE/kdegames/konquest/map/mapitems.cc 1254115 
>   trunk/KDE/kdegames/konquest/planet.cc 1254115 
>   trunk/KDE/kdegames/konquest/players/player.h 1254115 
>   trunk/KDE/kdegames/konquest/players/player.cpp 1254115 
> 
> Diff: http://svn.reviewboard.kde.org/r/6805/diff/diff
> 
> 
> Testing
> -------
> 
> Played the game, issued standing orders, ...
> 
> 
> Screenshots
> -----------
> 
> Spawn Fleet
>   http://svn.reviewboard.kde.org/r/6805/s/621/
> Fleet Overview
>   http://svn.reviewboard.kde.org/r/6805/s/622/
> Ships needed for standing orders in planet info
>   http://svn.reviewboard.kde.org/r/6805/s/623/
> 
> 
> Thanks,
> 
> Jeffrey Kelling
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111022/4cd1bb29/attachment.html>