[Kde-games-devel] Review Request: Konquest: Implement standing orders

[Pierre Ducroquet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6805/#review10444
-----------------------------------------------------------

Ship it!


Ship It!

- Pierre Ducroquet


On Sept. 18, 2011, 7:19 p.m., Jeffrey Kelling wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6805/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2011, 7:19 p.m.)
> 
> 
> Review request for KDE Games and Pierre Ducroquet.
> 
> 
> Description
> -------
> 
> This patch implements standing orders, i.e. orders that are repeated each turn if possible. Standing orders are issued the same way as normal order, additionally the added check box has to be checked. They are also removed the same way as normal orders (in the fleet overview). The orders are executed at the end of turn if enough ships are available, if not a message is issued. If the Planet is no longer under the players control the order is deleted. 
> 
> The number of ships that will be send due to standing order from a planet is displayed in that planets planet info (to its owner only).
> 
> 
> This addresses bug 87882.
>     https://bugs.kde.org/show_bug.cgi?id=87882
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/konquest/dialogs/fleetdlg.h 1254115 
>   trunk/KDE/kdegames/konquest/dialogs/fleetdlg.cc 1254115 
>   trunk/KDE/kdegames/konquest/game.h 1254115 
>   trunk/KDE/kdegames/konquest/game.cpp 1254115 
>   trunk/KDE/kdegames/konquest/gameview.h 1254115 
>   trunk/KDE/kdegames/konquest/gameview.cc 1254115 
>   trunk/KDE/kdegames/konquest/map/mapitems.cc 1254115 
>   trunk/KDE/kdegames/konquest/planet.cc 1254115 
>   trunk/KDE/kdegames/konquest/players/player.h 1254115 
>   trunk/KDE/kdegames/konquest/players/player.cpp 1254115 
> 
> Diff: http://svn.reviewboard.kde.org/r/6805/diff/diff
> 
> 
> Testing
> -------
> 
> Played the game, issued standing orders, ...
> 
> 
> Screenshots
> -----------
> 
> Spawn Fleet
>   http://svn.reviewboard.kde.org/r/6805/s/621/
> Fleet Overview
>   http://svn.reviewboard.kde.org/r/6805/s/622/
> Ships needed for standing orders in planet info
>   http://svn.reviewboard.kde.org/r/6805/s/623/
> 
> 
> Thanks,
> 
> Jeffrey Kelling
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111022/6902fc44/attachment-0001.html>