[Kde-games-devel] Re: Review Request: Port KLines to KGameRenderer

[Frederik Schwarzer]

> On April 20, 2011, 10:04 a.m., Frederik Schwarzer wrote:
> > Ok, it applies, compiles and runs smoothly here.
> > I cannot judge KGameRenderer-wise, though, since I did not have a look at its API yet.
> > But with so many OKs, I think it's save to commit, no? :)
> > 
> > One word though. KDELibs coding style is not a requirement for code in the Games module. While I try to use it, some do not. So if a game is maintained by someone else, please ask them for their opinion on the style. And please try to avoid mixing actual code changes with style changes.
> > 
> > I do not know if this applies to KLines or if you already asked. I just meant this generally.
> 
> Lindsay Mathieson wrote:
>     Thanks Frederik, in retrospect it was cheeky to apply astyle to the code, my apologies.
>     
>     If no one objects I'll go ahead and commit

Closing as Submitted. See r1229676.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5399/#review10070
-----------------------------------------------------------


On April 20, 2011, 5 a.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5399/
> -----------------------------------------------------------
> 
> (Updated April 20, 2011, 5 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Updates klines to use KGameRenderer and KGameRenderedItem in place of QSvgRenderer and QGraphicsPixmapItem
> Removes KPixmapCache usage
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/klines/animator.cpp 1228557 
>   /trunk/KDE/kdegames/klines/ballitem.h 1228557 
>   /trunk/KDE/kdegames/klines/ballitem.cpp 1228557 
>   /trunk/KDE/kdegames/klines/klines.cpp 1228557 
>   /trunk/KDE/kdegames/klines/previewitem.cpp 1228557 
>   /trunk/KDE/kdegames/klines/renderer.h 1228557 
>   /trunk/KDE/kdegames/klines/renderer.cpp 1228557 
>   /trunk/KDE/kdegames/klines/scene.cpp 1228557 
> 
> Diff: http://svn.reviewboard.kde.org/r/5399/diff
> 
> 
> Testing
> -------
> 
> Playing game
> Changing themes
> Resizing game
> Comparison with original
> 
> 
> Thanks,
> 
> Lindsay
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20110527/f53cd419/attachment-0001.htm