[Kde-games-devel] Re: Review Request: make kolf compilable with microsoft visual C++

[Miha Cancula]

> On March 23, 2011, 5:33 p.m., Miha Cancula wrote:
> > Sorry for a possibly out-of-line question, but isn't the proper way to do this using Q_UINT64_C? (http://doc.trolltech.org/latest/qtglobal.html#Q_UINT64_C)
> 
> Wolfgang Rohdewald wrote:
>     I did not yet know Q_UINT64_C (preferring Python) - but still this is mostly a copy of an external library with no Qt dependency. I think it should not differ too much from the original so I am committing ULL for now. BTW my test source has a bug - but it still works after fixing that

Ok, thanks. I didn't really look into the source, just that InvSqrt snippet. 


- Miha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6621/#review10002
-----------------------------------------------------------


On March 20, 2011, 10:39 a.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6621/
> -----------------------------------------------------------
> 
> (Updated March 20, 2011, 10:39 a.m.)
> 
> 
> Review request for kde-windows, KDE Games and Stefan Majewsky.
> 
> 
> Summary
> -------
> 
> this compiler does not know LLU for integer literals,
> it expects ULL
> 
> g++ 4.4.5 also works with ULL - it treats them both
> equal
> 
> it seems that ULL is more standard:
> http://gcc.gnu.org/onlinedocs/gcc/Long-Long.html
> http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2005/n1811.pdf
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kolf/external/Box2D/Common/b2Math.h 1225313 
> 
> Diff: http://svn.reviewboard.kde.org/r/6621/diff
> 
> 
> Testing
> -------
> 
> with g++ 4.4.5 LLU and ULL both do the same
> 
> #include <stdio.h>
> main() {
>  long long unsigned int a=0x5fe6eb50c7aa19f9LLU;
>  long long unsigned int b=0x5fe6eb50c7aa19f9ULL;
>  printf("value a:%llx\n",a); 
>  printf("value b:%llx\n",a); 
> }
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20110324/422f5a40/attachment.htm