[Kde-games-devel] Re: Review Request: Port KLines to KGameRenderer

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5399/#review9815
-----------------------------------------------------------


Not a KLines developer so just a few general hints.


/trunk/KDE/kdegames/klines/ballitem.cpp
<http://svn.reviewboard.kde.org/r/5399/#comment10935>

    Use QString() instead of "".
    QString() is a very cheap operation, it only creates the handle object, without any data.
    



/trunk/KDE/kdegames/klines/ballitem.cpp
<http://svn.reviewboard.kde.org/r/5399/#comment10936>

    Seems to change the coding style regarding whitespace within parentheses.



/trunk/KDE/kdegames/klines/renderer.h
<http://svn.reviewboard.kde.org/r/5399/#comment10937>

    Is this part of the comment still applicable after the change to "all members static"?



/trunk/KDE/kdegames/klines/renderer.cpp
<http://svn.reviewboard.kde.org/r/5399/#comment10938>

    Is this needed?



/trunk/KDE/kdegames/klines/renderer.cpp
<http://svn.reviewboard.kde.org/r/5399/#comment10939>

    When converting an ASCII string literal into a QString, using QLatin1String(literal) is preferable.
    I don't remember why exactly, I think it makes it faster to convert the 8bit literal into Qt's internal 16bit representation due to not having to consider UTF-8 multi byte sequences



/trunk/KDE/kdegames/klines/renderer.cpp
<http://svn.reviewboard.kde.org/r/5399/#comment10940>

    QString()


- Kevin


On Sept. 25, 2010, 12:41 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5399/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2010, 12:41 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Updates klines to use KGameRenderer and KGameRenderedItem in place of QSvgRenderer and QGraphicsPixmapItem
> Removes KPixmapCache usage
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/klines/scene.cpp 1177731 
>   /trunk/KDE/kdegames/klines/renderer.cpp 1177731 
>   /trunk/KDE/kdegames/klines/renderer.h 1177731 
>   /trunk/KDE/kdegames/klines/previewitem.cpp 1177731 
>   /trunk/KDE/kdegames/klines/klines.cpp 1177731 
>   /trunk/KDE/kdegames/klines/ballitem.cpp 1177731 
>   /trunk/KDE/kdegames/klines/ballitem.h 1177731 
>   /trunk/KDE/kdegames/klines/animator.cpp 1177731 
> 
> Diff: http://svn.reviewboard.kde.org/r/5399/diff
> 
> 
> Testing
> -------
> 
> Playing game
> Changing themes
> Resizing game
> Comparison with original
> 
> 
> Thanks,
> 
> Lindsay
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20110206/f2da5f55/attachment.htm