[Kde-games-devel] Review Request: kmahjongg: select the wrong Stone if i click on the shadow of another stone

[Christian Krippendorf]

> On Dec. 4, 2011, 3:28 a.m., Ian Wadham wrote:
> > The code looks good to me, but I have not tested it yet.
> > 
> > One picky little thing occurs to me.  Do the visible vertical faces of tiles count as "shadow" or "tile"?  Ideally they should count as "shadow" (i.e. you should select the *top* face of a tile).  But then what should happen if there is a tile underneath and partly in shadow?  Does clicking the vertical face select the lower tile (WRONG)?  Does clicking the vertical face select nothing at all (irritating)?  On balance and in the interests of practicality, I think clicking a vertical face should select the tile it is a part of.
> 
> Wolfgang Rohdewald wrote:
>     I agree with Ian but with two exceptions:
>     - If there is no other tile below the shadow it might be nice if clicking on the shadow also selects the tile
>     - if a tile fully covers a lower tile and the click would select the lower tile (on its vertical face or on its shadow), it should automatically select the upper tile
>     
>     that would reduce the change in behaviour to the really faulty situations

Sorry, but i don't know what u mean with "vertical faces". The side of the stone in 3D reflection? As this is part of the tile and not the shadow. If u click on such a side, that is not overlaid by another tile. The tile will get selected the side is related to. So it is like u said in the last sentence. (on my tests with the code here. :) )

@Wolfgang

Please NO!!!! A shadow is a shadow, that's all. Shadow should be like there is nothing. If clicking on a shadow selects the tile below (if there is one) and on the other side select the tile the shadow it is related to (if there is no tile below), people out there will think this could be a bug. The selection should work consistent, please.

@All

Feel free to test the code :)


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6839/#review10513
-----------------------------------------------------------


On Dec. 3, 2011, 1:34 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6839/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2011, 1:34 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=286927
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.h 1267104 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1267104 
> 
> Diff: http://svn.reviewboard.kde.org/r/6839/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111204/3a8d8e5b/attachment.html>