[Kde-games-devel] Review Request: kmahjongg: select the wrong Stone if i click on the shadow of another stone

[Ian Wadham]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6839/#review10513
-----------------------------------------------------------


The code looks good to me, but I have not tested it yet.

One picky little thing occurs to me.  Do the visible vertical faces of tiles count as "shadow" or "tile"?  Ideally they should count as "shadow" (i.e. you should select the *top* face of a tile).  But then what should happen if there is a tile underneath and partly in shadow?  Does clicking the vertical face select the lower tile (WRONG)?  Does clicking the vertical face select nothing at all (irritating)?  On balance and in the interests of practicality, I think clicking a vertical face should select the tile it is a part of.

- Ian Wadham


On Dec. 3, 2011, 1:34 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6839/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2011, 1:34 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=286927
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.h 1267104 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1267104 
> 
> Diff: http://svn.reviewboard.kde.org/r/6839/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111204/1e5e23bc/attachment.html>