[Kde-games-devel] Re: Review Request: Remove unused gifts from levelset

[Frederik Schwarzer]

> On April 3, 2011, 9:47 a.m., Julian Helfferich wrote:
> > I assume there were plans to include these gift types when the default levelset of KBreakout was created but since the old loadLevel() function did not issue any error messages about unsupported gift types they fell into oblivion. It would be nice, if Fela could comment on this. I would be happy with removing these lines from the levelset.
> 
> Frederik Schwarzer wrote:
>     I wrote him an email.

Since Fela did not answer yet and already said about a year ago, that his free time went away for other stuff (seriously, ruby?! ;)), I will commmit this in the next few days, if no objections occur.
I can see no harm in this change and it removes some confusion in times of coming level editors, since this file will be used as some kind of reference, I suppose.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6655/#review10047
-----------------------------------------------------------


On April 1, 2011, 2:38 a.m., Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6655/
> -----------------------------------------------------------
> 
> (Updated April 1, 2011, 2:38 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch removes all unused gifts from the default level set. Neither are they used in any of the current themes nor handled in the source code.
> 
> Or were there other plans for those gifts?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbreakout/levelsets/default.levelset 1226683 
> 
> Diff: http://svn.reviewboard.kde.org/r/6655/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20110408/594b2ec1/attachment.htm