[Kde-games-devel] Re: Review Request: Rename games that have active trademarks (KTron, KBattleship)

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5804/#review8565
-----------------------------------------------------------



/trunk/KDE/kdegames/kbattleship/src/main.cpp
<http://svn.reviewboard.kde.org/r/5804/#comment8951>

    "sinking ships" -> "ship sinking"?



/trunk/KDE/kdegames/ktron/ktron.desktop
<http://svn.reviewboard.kde.org/r/5804/#comment8952>

    The generic name should either be removed or made more descriptive. Uninformative generic names are worse than no generic name at all.



/trunk/KDE/kdegames/ktron/main.cpp
<http://svn.reviewboard.kde.org/r/5804/#comment8953>

    These two lines should be removed, since the switch isn't used.


What about the application manuals?

- Parker


On 2010-11-08 20:44:53, Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5804/
> -----------------------------------------------------------
> 
> (Updated 2010-11-08 20:44:53)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Renaming 2 games that have active trademarks, KTron (Tron) and KBattleship (Battleship).  Per http://piacentini.blog.br/2010/11/renaming-kbattleships-and-ktron/ , the new names chosen are "KSnakeDuel" and "Naval Battle", respectively.
> 
> This initial patch changes only the user-visible portions of code and data.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbattleship/src/kbattleship.desktop 1194354 
>   /trunk/KDE/kdegames/kbattleship/src/kbattleship.protocol 1194354 
>   /trunk/KDE/kdegames/kbattleship/src/main.cpp 1194354 
>   /trunk/KDE/kdegames/kbattleship/src/message.cpp 1194354 
>   /trunk/KDE/kdegames/kbattleship/src/playfield.cpp 1194354 
>   /trunk/KDE/kdegames/ktron/general.ui 1194354 
>   /trunk/KDE/kdegames/ktron/ktron.desktop 1194354 
>   /trunk/KDE/kdegames/ktron/main.cpp 1194354 
>   /trunk/KDE/kdegames/ktron/player.cpp 1194354 
>   /trunk/KDE/kdegames/ktron/themes/default.desktop 1194354 
>   /trunk/KDE/kdegames/ktron/themes/neon.desktop 1194354 
> 
> Diff: http://svn.reviewboard.kde.org/r/5804/diff
> 
> 
> Testing
> -------
> 
> Patches similar to this one (using KSnakeDuel and KSinkShips) have been included in fedora since... well, a long time. :)
> 
> 
> Thanks,
> 
> Rex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20101108/cdde593d/attachment.htm