<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5804/">http://svn.reviewboard.kde.org/r/5804/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5804/diff/1/?file=40828#file40828line25" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/kbattleship/src/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ki18n</span><span class="p">(</span><span class="s">"The KDE <span class="hl">Battle</span>ship<span class="hl"> clon</span>e"</span><span class="p">),</span> <span class="n">KAboutData</span><span class="o">::</span><span class="n">License_GPL</span><span class="p">,</span><span class="ew"> </span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ki18n</span><span class="p">(</span><span class="s">"The KDE <span class="hl">sinking </span>ship<span class="hl">s gam</span>e"</span><span class="p">),</span> <span class="n">KAboutData</span><span class="o">::</span><span class="n">License_GPL</span><span class="p">,</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"sinking ships" -> "ship sinking"?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5804/diff/1/?file=40832#file40832line6" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/ktron/ktron.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GenericName=<span class="hl">Tron-like</span> Game</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GenericName=<span class="hl">Snake Duel</span> Game</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The generic name should either be removed or made more descriptive. Uninformative generic names are worse than no generic name at all.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5804/diff/1/?file=40833#file40833line53" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/ktron/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static KLocalizedString notice = ki18n("(c) 1998-2000, Matthias Kiefer\n"</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">options</span><span class="p">.</span><span class="n">add</span><span class="p">(</span><span class="s">"ktron"</span><span class="p">,</span> <span class="n">ki18n</span><span class="p">(</span><span class="s">"Start in KTron mode"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// This is the default anyway, why does this need an option? -- Kevin Kofler</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// options.add("ktron", ki18n("Start in KTron mode"));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These two lines should be removed, since the switch isn't used.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about the application manuals?</pre>
<p>- Parker</p>
<br />
<p>On November 8th, 2010, 8:44 p.m., Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated 2010-11-08 20:44:53</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Renaming 2 games that have active trademarks, KTron (Tron) and KBattleship (Battleship). Per http://piacentini.blog.br/2010/11/renaming-kbattleships-and-ktron/ , the new names chosen are "KSnakeDuel" and "Naval Battle", respectively.
This initial patch changes only the user-visible portions of code and data.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patches similar to this one (using KSnakeDuel and KSinkShips) have been included in fedora since... well, a long time. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/kbattleship/src/kbattleship.desktop <span style="color: grey">(1194354)</span></li>
<li>/trunk/KDE/kdegames/kbattleship/src/kbattleship.protocol <span style="color: grey">(1194354)</span></li>
<li>/trunk/KDE/kdegames/kbattleship/src/main.cpp <span style="color: grey">(1194354)</span></li>
<li>/trunk/KDE/kdegames/kbattleship/src/message.cpp <span style="color: grey">(1194354)</span></li>
<li>/trunk/KDE/kdegames/kbattleship/src/playfield.cpp <span style="color: grey">(1194354)</span></li>
<li>/trunk/KDE/kdegames/ktron/general.ui <span style="color: grey">(1194354)</span></li>
<li>/trunk/KDE/kdegames/ktron/ktron.desktop <span style="color: grey">(1194354)</span></li>
<li>/trunk/KDE/kdegames/ktron/main.cpp <span style="color: grey">(1194354)</span></li>
<li>/trunk/KDE/kdegames/ktron/player.cpp <span style="color: grey">(1194354)</span></li>
<li>/trunk/KDE/kdegames/ktron/themes/default.desktop <span style="color: grey">(1194354)</span></li>
<li>/trunk/KDE/kdegames/ktron/themes/neon.desktop <span style="color: grey">(1194354)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5804/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>