[Kde-games-devel] Review Request: Added difficuly level into kbounce.

[Parker Coates]

On Sat, Mar 20, 2010 at 07:53, Andreas Scherf wrote:
> Am Samstag, 20. März 2010 schrieb Parker Coates:
>> On Sat, Mar 20, 2010 at 05:26, Andreas Scherf wrote:
>> > Removed all whitespace changes inside the diff.
>>
>> All whitespace only changes were removed, but in the lines you did
>> change, there were sill a few cases where tabs were replaced by
>> spaces. See the attached patch, which fixes these as well. I hadn't
>> realised how messed up the KBounce indentation was. Some files are
>> spaces only, some are tabs only and some are tabs followed by spaces
>> for half levels of indentation. Not very pretty.
>>
>> Other than that, I would say this is ready to be committed. Do you
>> have SVN access, or do you need someone to commit this for you?
>
> Ok, i have svn acess (the last commits to kbounce are from myself ).
> I took your diff and patch the trunk sources with that. But after that i want
> to make some more changes to kbounce. As i mentioned before.
> Yes the code itself has some different identities and it is hard to choose the
> one for editing. What about reformating the code with the style guide from
> killbots? Or does this change too much ...

I would say it would be reasonable to do an big indentation change.
The majority of lines are using four spaces for indentation, so I'd
say you should just copy that everywhere. Also turn the
remove-trailing-whitespace-when-saving option in Kate so we can get
rid of that too.

I wouldn't try to use an automated tool for the tab to space
conversion, as some code seems to be assuming a tab width of 8
characters while other code seems to assume 4 characters.

Parker