[Kde-games-devel] Review Request: New classes KGameRenderer and KGameRenderedItem

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4283/#review6114
-----------------------------------------------------------



trunk/KDE/kdegames/kdiamond/src/staging.h
<http://reviewboard.kde.org/r/4283/#comment5708>

    I think it would probably make sense to have a setSpriteKey(QString) method.



trunk/KDE/kdegames/kdiamond/src/staging.cpp
<http://reviewboard.kde.org/r/4283/#comment5705>

    Hardcoding the cache name based on the app name could be a problem for games like KGoldrunner that use multiple SVGs. I'm not really sure what the best way of handling that would be.



trunk/KDE/kdegames/kdiamond/src/staging.cpp
<http://reviewboard.kde.org/r/4283/#comment5706>

    This is just a matter of personal style, but I'm curious of why you don't just use a foreach loop.



trunk/KDE/kdegames/kdiamond/src/staging.cpp
<http://reviewboard.kde.org/r/4283/#comment5709>

    Since m_item is never used, I'm assuming this code should be removed?



trunk/KDE/kdegames/kdiamond/src/staging_p.h
<http://reviewboard.kde.org/r/4283/#comment5707>

    From the API docs it seems that KImageCache already contains an in-memory, process-local cache. Why add another layer on top of it?


- Parker


On 2010-06-13 20:54:58, Stefan Majewsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4283/
> -----------------------------------------------------------
> 
> (Updated 2010-06-13 20:54:58)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> KGameRenderer is a small SVG->PNG rendering framework for use in KDE games. For the story behind it, see http://kde.markmail.org/message/plfkwfeoni6nvpk2
> 
> This diff reflects the current state of my local work branch: KGameRenderer is in a single source file inside the KDiamond source tree. I am in the process of porting KDiamond to KGameRenderer alongside writing KGameRenderer for testing reasons.
> 
> The relevant code is in the files "staging(-p)?.(h|cpp)". Eventually, KGameRenderer shall be moved inside libkdegames. I will take care of porting all applications in the kdegames module to KGameRenderer where it is fruitful.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kdiamond/src/staging.h PRE-CREATION 
>   trunk/KDE/kdegames/kdiamond/src/staging.cpp PRE-CREATION 
>   trunk/KDE/kdegames/kdiamond/src/staging_p.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4283/diff
> 
> 
> Testing
> -------
> 
> KDiamond still works, and even feels a bit faster although I have yet to fully take advantage of KGameRenderer's facilities.
> 
> 
> Thanks,
> 
> Stefan
> 
>