[Kde-games-devel] Review Request: Make libkcardgame public

[Pino Toscano]

> On 2010-06-07 16:43:14, Pino Toscano wrote:
> > > CMakeLists.txt should install libkcardgame headers.
> > 
> > Why it "should"?
> > If the library is still in the kpat sources and its headers are not installed, it means it is not ready yet to be public;
> > what is your reason for wanting it public?
> 
> The-User wrote:
>     Because it is a library. In playground-libs the headers get installed, too...
>     What do you mean with "not ready", kpat can use it, so why shouldn't other apps use it?

So? Stuff in playground is mostly not released stuff, so what they install has no importance at that point.
kdegames is a released module, so what it installs needs more attention; especially public libraries, which can be used by 3rd party applications.
A library can be done for various reasons, but it not imply that everything must be public immediately. Especially in case of the said kcardgame library, which is still in heavy development, so it cannot guarantee any bit of compatibility, yet. When it is more API- and ABI- stable (and when its maintainer feels like it is), it will be made public. Surely not because "it is a library, so it must be public" (which is kind of nonsense).


- Pino


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4251/#review6016
-----------------------------------------------------------


On 2010-06-07 16:34:12, The-User wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4251/
> -----------------------------------------------------------
> 
> (Updated 2010-06-07 16:34:12)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> CMakeLists.txt should install libkcardgame headers.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kpat/libkcardgame/CMakeLists.txt 1135448 
>   trunk/KDE/kdegames/kpat/libkcardgame/include/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4251/diff
> 
> 
> Testing
> -------
> 
> works...
> 
> 
> Thanks,
> 
> The-User
> 
>