[Kde-games-devel] Review Request: Make libkcardgame public

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4251/#review6019
-----------------------------------------------------------


There needs to be a "Don't Ship It" checkbox. ;)

LibKCardGame is, for the time being, a private library internal to KPat. I've basically just been taking code that was already in KPat, cleaning it up, extracting out the KPat specific parts and moving it to the library. Although I'm happy enough with the progress made during the 4.5 dev cycle, LibKCardGame does not yet have the API stability, generality, documentation or external users to justify making it public at this point. For SC4.6 my plan is to clean it up further, add API docs, port LSkat to it and make it public.

So thank you for your concern and for the patch, but for the time being LibKCardGame should be considered as just some internal KPat code that is stored in a separate binary for some reason.

- Parker


On 2010-06-07 16:34:12, The-User wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4251/
> -----------------------------------------------------------
> 
> (Updated 2010-06-07 16:34:12)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> CMakeLists.txt should install libkcardgame headers.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kpat/libkcardgame/CMakeLists.txt 1135448 
>   trunk/KDE/kdegames/kpat/libkcardgame/include/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4251/diff
> 
> 
> Testing
> -------
> 
> works...
> 
> 
> Thanks,
> 
> The-User
> 
>