[Kde-games-devel] Review Request: Added some more options to konquest and allow map editing.

[Sean D'Epagnier]

> On 2010-01-24 23:04:11, Pierre Ducroquet wrote:
> > /trunk/KDE/kdegames/konquest/gamelogic.h, line 60
> > <http://reviewboard.kde.org/r/2681/diff/1/?file=17493#file17493line60>
> >
> >     What is blindBreak ?

This allows multiple human players sharing the pc to play a blind game (can't see each others ship counts) Because of this, there is an additional message box at the end of the turn in this case where no ships are shown and the game can be turned over to the next player.


> On 2010-01-24 23:04:11, Pierre Ducroquet wrote:
> > /trunk/KDE/kdegames/konquest/map.cc, line 130
> > <http://reviewboard.kde.org/r/2681/diff/1/?file=17497#file17497line130>
> >
> >     I strongly disagree with this one.
> >     We used planet names on a single char because it made it possible to play 100% with keyboard.

The new code still uses single char planet names.  I added this code because I allowed adding and deleting planets from the game setup.

It has always not been possible to have keyboard gameplay more planets than letters (and a few symbols)  

I noticed also that playing with the keyboard does not deselect the previous planet properly, and it continues to blink.  I can fix this with a separate patch.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2681/#review3854
-----------------------------------------------------------


On 2010-01-22 02:57:50, Sean D'Epagnier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2681/
> -----------------------------------------------------------
> 
> (Updated 2010-01-22 02:57:50)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Various changes to konquest to support more gameplay options and dynamics.  It is also possible to customize the map entirely without relying on lots of map rejections.
> 
> I plan to do a lot more improvements on konquest in the future.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/konquest/Konquest.cc 1078318 
>   /trunk/KDE/kdegames/konquest/fleet.cc 1078318 
>   /trunk/KDE/kdegames/konquest/gamelogic.h 1078318 
>   /trunk/KDE/kdegames/konquest/gamelogic.cc 1078318 
>   /trunk/KDE/kdegames/konquest/gameview.cc 1078318 
>   /trunk/KDE/kdegames/konquest/map.h 1078318 
>   /trunk/KDE/kdegames/konquest/map.cc 1078318 
>   /trunk/KDE/kdegames/konquest/mapitems.h 1078318 
>   /trunk/KDE/kdegames/konquest/mapitems.cc 1078318 
>   /trunk/KDE/kdegames/konquest/mapscene.h 1078318 
>   /trunk/KDE/kdegames/konquest/mapscene.cc 1078318 
>   /trunk/KDE/kdegames/konquest/mapview.cc 1078318 
>   /trunk/KDE/kdegames/konquest/minimapview.h 1078318 
>   /trunk/KDE/kdegames/konquest/minimapview.cc 1078318 
>   /trunk/KDE/kdegames/konquest/newGameDialog.ui 1078318 
>   /trunk/KDE/kdegames/konquest/newgamedlg.h 1078318 
>   /trunk/KDE/kdegames/konquest/newgamedlg.cc 1078318 
>   /trunk/KDE/kdegames/konquest/planet.h 1078318 
>   /trunk/KDE/kdegames/konquest/planet.cc 1078318 
>   /trunk/KDE/kdegames/konquest/player.h 1078318 
>   /trunk/KDE/kdegames/konquest/player.cc 1078318 
> 
> Diff: http://reviewboard.kde.org/r/2681/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sean
> 
>