[Kde-games-devel] Review Request: Added some more options to konquest and allow map editing.

[Pierre Ducroquet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2681/#review3854
-----------------------------------------------------------


That patch is really hard to review. Please, next time, split it in several parts !
I've gone through about half the changes so far, with two remarks. 
But if you could split the patch in many small patches containing only one feature, it'd be great.


/trunk/KDE/kdegames/konquest/gamelogic.h
<http://reviewboard.kde.org/r/2681/#comment3248>

    What is blindBreak ?



/trunk/KDE/kdegames/konquest/map.cc
<http://reviewboard.kde.org/r/2681/#comment3249>

    I strongly disagree with this one.
    We used planet names on a single char because it made it possible to play 100% with keyboard.


- Pierre


On 2010-01-22 02:57:50, Sean D'Epagnier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2681/
> -----------------------------------------------------------
> 
> (Updated 2010-01-22 02:57:50)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Various changes to konquest to support more gameplay options and dynamics.  It is also possible to customize the map entirely without relying on lots of map rejections.
> 
> I plan to do a lot more improvements on konquest in the future.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/konquest/Konquest.cc 1078318 
>   /trunk/KDE/kdegames/konquest/fleet.cc 1078318 
>   /trunk/KDE/kdegames/konquest/gamelogic.h 1078318 
>   /trunk/KDE/kdegames/konquest/gamelogic.cc 1078318 
>   /trunk/KDE/kdegames/konquest/gameview.cc 1078318 
>   /trunk/KDE/kdegames/konquest/map.h 1078318 
>   /trunk/KDE/kdegames/konquest/map.cc 1078318 
>   /trunk/KDE/kdegames/konquest/mapitems.h 1078318 
>   /trunk/KDE/kdegames/konquest/mapitems.cc 1078318 
>   /trunk/KDE/kdegames/konquest/mapscene.h 1078318 
>   /trunk/KDE/kdegames/konquest/mapscene.cc 1078318 
>   /trunk/KDE/kdegames/konquest/mapview.cc 1078318 
>   /trunk/KDE/kdegames/konquest/minimapview.h 1078318 
>   /trunk/KDE/kdegames/konquest/minimapview.cc 1078318 
>   /trunk/KDE/kdegames/konquest/newGameDialog.ui 1078318 
>   /trunk/KDE/kdegames/konquest/newgamedlg.h 1078318 
>   /trunk/KDE/kdegames/konquest/newgamedlg.cc 1078318 
>   /trunk/KDE/kdegames/konquest/planet.h 1078318 
>   /trunk/KDE/kdegames/konquest/planet.cc 1078318 
>   /trunk/KDE/kdegames/konquest/player.h 1078318 
>   /trunk/KDE/kdegames/konquest/player.cc 1078318 
> 
> Diff: http://reviewboard.kde.org/r/2681/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sean
> 
>