[Kde-games-devel] Review Request: Port KBlocks to KGameRenderer

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5081/#review7161
-----------------------------------------------------------


Did not test-compile yet, but here are some comments on the code.


/trunk/KDE/kdegames/kblocks/KBlocksGraphics.h
<http://reviewboard.kde.org/r/5081/#comment7299>

    Should be <KGameRenderer>.



/trunk/KDE/kdegames/kblocks/KBlocksScene.cpp
<http://reviewboard.kde.org/r/5081/#comment7302>

    Could you please check if this is still needed with revision 1167001 of libkdegames trunk?



/trunk/KDE/kdegames/kblocks/KBlocksScene.cpp
<http://reviewboard.kde.org/r/5081/#comment7300>

    Could you please do this with setBackgroundBrush, as in the other games, in order to avoid repeated spritePixmap() calls?



/trunk/KDE/kdegames/kblocks/KBlocksSvgItem.cpp
<http://reviewboard.kde.org/r/5081/#comment7301>

    If you want, you can do this with setSpriteKey("BLOCK"), setFrame(mColor). But that's a question of personal style, so I'll leave it to you.


- Stefan


On 2010-08-23 01:04:01, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5081/
> -----------------------------------------------------------
> 
> (Updated 2010-08-23 01:04:01)
> 
> 
> Review request for KDE Games, Mauricio Piacentini and Stefan Majewsky.
> 
> 
> Summary
> -------
> 
> This straightforward patch makes the KBlocks rendering code use KGameRenderer instead of making its own KGameTheme and QSvgRenderer instances
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kblocks/KBlocksGraphics.h 1166816 
>   /trunk/KDE/kdegames/kblocks/KBlocksGraphics.cpp 1166816 
>   /trunk/KDE/kdegames/kblocks/KBlocksItemGroup.cpp 1166816 
>   /trunk/KDE/kdegames/kblocks/KBlocksScene.cpp 1166816 
>   /trunk/KDE/kdegames/kblocks/KBlocksSvgItem.h 1166816 
>   /trunk/KDE/kdegames/kblocks/KBlocksSvgItem.cpp 1166816 
>   /trunk/KDE/kdegames/kblocks/main.cpp 1166816 
> 
> Diff: http://reviewboard.kde.org/r/5081/diff
> 
> 
> Testing
> -------
> 
> I have tested playing games and switching themes, and encountered no problems.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100823/0a784795/attachment-0001.htm