[Kde-games-devel] Review Request: Port KBreakout to use KGameRenderer

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5061/#review7154
-----------------------------------------------------------


Looks good to me, but I would like to hear the opinion of maintainer Fela Winkelmolen, who seems not to have a Reviewboard account. I will contact him personally.

- Stefan


On 2010-08-17 21:21:05, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5061/
> -----------------------------------------------------------
> 
> (Updated 2010-08-17 21:21:05)
> 
> 
> Review request for KDE Games and Stefan Majewsky.
> 
> 
> Summary
> -------
> 
> This patch ports KBreakout to use KGameRenderer.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbreakout/src/CMakeLists.txt 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/ball.cpp 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/brick.h 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/brick.cpp 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/canvasitems.cpp 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/canvaswidget.h 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/canvaswidget.cpp 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/gift.cpp 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/item.h 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/item.cpp 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/main.cpp 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/mainwindow.h 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/mainwindow.cpp 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/textitems.h 1164677 
>   /trunk/KDE/kdegames/kbreakout/src/textitems.cpp 1164677 
> 
> Diff: http://reviewboard.kde.org/r/5061/diff
> 
> 
> Testing
> -------
> 
> Everything seems to work, including theme changes, changes to new levels, game resets, and the showing/hiding of all text labels in the aforementioned situations.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100822/5dbd5319/attachment.htm