[Kde-games-devel] Review Request: Port Kollision to use KGameRenderer

Brian Croom brian.s.croom at gmail.com
Tue Aug 17 17:20:32 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5059/
-----------------------------------------------------------

(Updated 2010-08-17 15:20:31.986224)


Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.


Changes
-------

I made the recommended changes/tweaks.

Btw (OT), I'm getting scroll bars on the QGraphicsView, as the view apparently isn't large enough for the scene due to the scroll bars, menu, and status bar. This really ought to be fixed, however I'm not so sure how to do it.


Summary
-------

This patch ports Kollision to use the KGameRenderer class for rendering balls.


Diffs (updated)
-----

  /trunk/KDE/kdegames/kollision/CMakeLists.txt 1164677 
  /trunk/KDE/kdegames/kollision/ball.h 1164677 
  /trunk/KDE/kdegames/kollision/ball.cpp 1164677 
  /trunk/KDE/kdegames/kollision/main.cpp 1164677 
  /trunk/KDE/kdegames/kollision/mainarea.h 1164677 
  /trunk/KDE/kdegames/kollision/mainarea.cpp 1164677 
  /trunk/KDE/kdegames/kollision/pictures/CMakeLists.txt 1164677 
  /trunk/KDE/kdegames/kollision/renderer.h 1164677 
  /trunk/KDE/kdegames/kollision/renderer.cpp 1164677 

Diff: http://reviewboard.kde.org/r/5059/diff


Testing
-------

Everything seems to work.


Thanks,

Brian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100817/1b9eb55e/attachment-0001.htm 


More information about the kde-games-devel mailing list