[Kde-games-devel] Review Request: Port KReversi to use KGameRenderer

[Dmitry Suzdalev]

> On 2010-08-10 08:26:54, Dmitry Suzdalev wrote:
> > /trunk/KDE/kdegames/kreversi/kreversichip.cpp, line 32
> > <http://reviewboard.kde.org/r/4948/diff/3/?file=33457#file33457line32>
> >
> >     Let's have it static here, no need for it to be exportable I guess :)
> >     
> >     This is just my rule of thumb - every local variable in each compilation unit should be made static (and preferably const) if not needed otherwise.
> >     
> >     I mean 
> >     static QPixmap* ...
> 
> Brian Croom wrote:
>     /home/bcroom2/kde/src/4/kdegames/kreversi/kreversichip.cpp:32: error: 'static' may not be used when defining (as opposed to declaring) a static data member
>     
>     :)

oh, right. i overlooked that it is a static member of a class, though it is a global object :)
nevermined then.


- Dmitry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4948/#review6928
-----------------------------------------------------------


On 2010-08-10 15:18:48, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4948/
> -----------------------------------------------------------
> 
> (Updated 2010-08-10 15:18:48)
> 
> 
> Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.
> 
> 
> Summary
> -------
> 
> This patch modifies KReversi to use KGameRenderer for loading its theme and generating/receiving its pixmaps. This is my first port attempt (first KDE contribution woohoo!) so please critique.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kreversi/CMakeLists.txt 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversichip.h 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversichip.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversirenderer.h 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversirenderer.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversiscene.h 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversiscene.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/main.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/mainwindow.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/pics/CMakeLists.txt 1161066 
>   /trunk/KDE/kdegames/kreversi/pics/default_theme.desktop PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4948/diff
> 
> 
> Testing
> -------
> 
> I have tested the various hinting/marking options, changing chip color set, etc. Everything seems to be working.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100810/d7b69e4c/attachment-0001.htm