[Kde-games-devel] Review Request: Port KReversi to use KGameRenderer

[Brian Croom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4948/
-----------------------------------------------------------

(Updated 2010-08-10 15:18:48.124070)


Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.


Changes
-------

Add copyright/credit. Remove translations from default_theme.desktop.


Summary
-------

This patch modifies KReversi to use KGameRenderer for loading its theme and generating/receiving its pixmaps. This is my first port attempt (first KDE contribution woohoo!) so please critique.


Diffs (updated)
-----

  /trunk/KDE/kdegames/kreversi/CMakeLists.txt 1161066 
  /trunk/KDE/kdegames/kreversi/kreversichip.h 1161066 
  /trunk/KDE/kdegames/kreversi/kreversichip.cpp 1161066 
  /trunk/KDE/kdegames/kreversi/kreversirenderer.h 1161066 
  /trunk/KDE/kdegames/kreversi/kreversirenderer.cpp 1161066 
  /trunk/KDE/kdegames/kreversi/kreversiscene.h 1161066 
  /trunk/KDE/kdegames/kreversi/kreversiscene.cpp 1161066 
  /trunk/KDE/kdegames/kreversi/main.cpp 1161066 
  /trunk/KDE/kdegames/kreversi/mainwindow.cpp 1161066 
  /trunk/KDE/kdegames/kreversi/pics/CMakeLists.txt 1161066 
  /trunk/KDE/kdegames/kreversi/pics/default_theme.desktop PRE-CREATION 

Diff: http://reviewboard.kde.org/r/4948/diff


Testing
-------

I have tested the various hinting/marking options, changing chip color set, etc. Everything seems to be working.


Thanks,

Brian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100810/43f0d01c/attachment.htm