[Kde-games-devel] Review Request: Port KAtomic to use KGameRenderer

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4956/#review6929
-----------------------------------------------------------


Looks very nice, although I won't commit that before having compiled it myself. Also, I think Dmitry wants to have a look at this, too.


/trunk/KDE/kdegames/katomic/fielditem.h
<http://reviewboard.kde.org/r/4956/#comment6910>

    Since KGameRendererClient::setRenderSize is not virtual, making this method virtual is unnecessary.



/trunk/KDE/kdegames/katomic/playfield.cpp
<http://reviewboard.kde.org/r/4956/#comment6912>

    While we're at it, you could simplify that by using QGraphicsScene::setBackgroundBrush (though that's not a must).
    
    See updateGraphics() in kdiamond/src/game.cpp for an example.


- Stefan


On 2010-08-09 19:05:20, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4956/
> -----------------------------------------------------------
> 
> (Updated 2010-08-09 19:05:20)
> 
> 
> Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.
> 
> 
> Summary
> -------
> 
> This patch ports KAtomic to use the KGameRenderer class instead its own renderer.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/katomic/CMakeLists.txt 1161066 
>   /trunk/KDE/kdegames/katomic/default_theme.desktop PRE-CREATION 
>   /trunk/KDE/kdegames/katomic/fielditem.h 1161066 
>   /trunk/KDE/kdegames/katomic/fielditem.cpp 1161066 
>   /trunk/KDE/kdegames/katomic/katomicrenderer.h 1161066 
>   /trunk/KDE/kdegames/katomic/katomicrenderer.cpp 1161066 
>   /trunk/KDE/kdegames/katomic/playfield.h 1161066 
>   /trunk/KDE/kdegames/katomic/playfield.cpp 1161066 
> 
> Diff: http://reviewboard.kde.org/r/4956/diff
> 
> 
> Testing
> -------
> 
> Everything seems to be working properly.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100809/0b358e19/attachment.htm