<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4956/">http://reviewboard.kde.org/r/4956/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks very nice, although I won&#39;t commit that before having compiled it myself. Also, I think Dmitry wants to have a look at this, too.</pre>
 <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="/r/4956/diff/2/?file=33444#file33444line78" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/katomic/fielditem.h</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="k">virtual</span> <span class="kt">void</span> <span class="n">setRenderSize</span><span class="p">(</span><span class="k">const</span> <span class="n">QSize</span><span class="o">&amp;</span> <span class="n">renderSize</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since KGameRendererClient::setRenderSize is not virtual, making this method virtual is unnecessary.</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="/r/4956/diff/2/?file=33449#file33449line664" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/katomic/playfield.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PlayField::updateArrows(bool justHide)</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">656</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">p</span><span class="o">-&gt;</span><span class="n">drawPixmap</span><span class="p">(</span><span class="mi">0</span><span class="p">,</span> <span class="mi">0</span><span class="p">,</span> <span class="n"><span class="hl">KAtomicR</span>enderer</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">self</span></span><span class="p"><span class="hl">()</span></span><span class="o"><span class="hl">-&gt;</span></span><span class="n"><span class="hl">renderB</span>ackground</span><span class="p"><span class="hl">(</span></span> <span class="n">sceneRect</span><span class="p">().</span><span class="n">size</span><span class="p">().</span><span class="n">toSize</span><span class="p">()</span> <span class="p">));</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">662</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">p</span><span class="o">-&gt;</span><span class="n">drawPixmap</span><span class="p">(</span><span class="mi">0</span><span class="p">,</span> <span class="mi">0</span><span class="p">,</span> <span class="n"><span class="hl">m_r</span>enderer</span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">spritePixmap</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">&quot;b</span>ackground<span class="hl">&quot;</span></span><span class="p"><span class="hl">,</span></span> <span class="n">sceneRect</span><span class="p">().</span><span class="n">size</span><span class="p">().</span><span class="n">toSize</span><span class="p">()));</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While we&#39;re at it, you could simplify that by using QGraphicsScene::setBackgroundBrush (though that&#39;s not a must).

See updateGraphics() in kdiamond/src/game.cpp for an example.</pre>
</div>
<br />



<p>- Stefan</p>


<br />
<p>On August 9th, 2010, 7:05 p.m., Brian Croom wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.</div>
<div>By Brian Croom.</div>


<p style="color: grey;"><i>Updated 2010-08-09 19:05:20</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch ports KAtomic to use the KGameRenderer class instead its own renderer.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything seems to be working properly.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdegames/katomic/CMakeLists.txt <span style="color: grey">(1161066)</span></li>

 <li>/trunk/KDE/kdegames/katomic/default_theme.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdegames/katomic/fielditem.h <span style="color: grey">(1161066)</span></li>

 <li>/trunk/KDE/kdegames/katomic/fielditem.cpp <span style="color: grey">(1161066)</span></li>

 <li>/trunk/KDE/kdegames/katomic/katomicrenderer.h <span style="color: grey">(1161066)</span></li>

 <li>/trunk/KDE/kdegames/katomic/katomicrenderer.cpp <span style="color: grey">(1161066)</span></li>

 <li>/trunk/KDE/kdegames/katomic/playfield.h <span style="color: grey">(1161066)</span></li>

 <li>/trunk/KDE/kdegames/katomic/playfield.cpp <span style="color: grey">(1161066)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4956/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>