[Kde-games-devel] Review Request: Port KReversi to use KGameRenderer

[Brian Croom]

> On 2010-08-09 19:11:04, Dmitry Suzdalev wrote:
> > /trunk/KDE/kdegames/kreversi/kreversichip.cpp, line 98
> > <http://reviewboard.kde.org/r/4948/diff/2/?file=33386#file33386line98>
> >
> >     I guess this is looking more or less ok?
> >     Used to draw grayish background.
> >     
> >     Maybe this indication should even be replaced by some nice and simple animation effect in future.

I have restored the gray background, which I think does look better than the transparency.


> On 2010-08-09 19:11:04, Dmitry Suzdalev wrote:
> > /trunk/KDE/kdegames/kreversi/kreversichip.cpp, line 113
> > <http://reviewboard.kde.org/r/4948/diff/2/?file=33386#file33386line113>
> >
> >     I'd give this function a more descriptive name, so it would be easy to read source later on.
> >     
> >     Maybe currentFrameNumber() or currentFrame().

Changed.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4948/#review6922
-----------------------------------------------------------


On 2010-08-09 17:00:17, Brian Croom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4948/
> -----------------------------------------------------------
> 
> (Updated 2010-08-09 17:00:17)
> 
> 
> Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.
> 
> 
> Summary
> -------
> 
> This patch modifies KReversi to use KGameRenderer for loading its theme and generating/receiving its pixmaps. This is my first port attempt (first KDE contribution woohoo!) so please critique.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kreversi/CMakeLists.txt 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversichip.h 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversichip.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversirenderer.h 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversirenderer.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversiscene.h 1161066 
>   /trunk/KDE/kdegames/kreversi/kreversiscene.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/mainwindow.cpp 1161066 
>   /trunk/KDE/kdegames/kreversi/pics/CMakeLists.txt 1161066 
>   /trunk/KDE/kdegames/kreversi/pics/default_theme.desktop PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4948/diff
> 
> 
> Testing
> -------
> 
> I have tested the various hinting/marking options, changing chip color set, etc. Everything seems to be working.
> 
> 
> Thanks,
> 
> Brian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100809/e08e517f/attachment-0001.htm