[Kde-games-devel] Review Request: Hint in Kiriki

Nicolás Alvarez nicolas.alvarez at gmail.com
Sun Apr 25 19:14:49 CEST 2010



> On None, Parker Coates wrote:
> > /trunk/KDE/kdegames/kiriki/src/kiriki.cpp, lines 219-220
> > <http://reviewboard.kde.org/r/3793/diff/1/?file=24412#file24412line219>
> >
> >     The singular word is "die" and the plural is "dice". I don't think "dices" is a word at all.

And that should be using i18np(), not an if() for <=1. Some languages have more than two plural forms, or at least use the plural form for zero.


- Nicolás


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3793/#review5218
-----------------------------------------------------------


On 2010-04-23 17:53:19, Luiz Romário Santana Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3793/
> -----------------------------------------------------------
> 
> (Updated 2010-04-23 17:53:19)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch implements hint in Kiriki, using the computer itself to give it. The tips are shown in the status bar - that is hidden right after the roll.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.h 1117862 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1117862 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.h 1117862 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp 1117862 
>   /trunk/KDE/kdegames/kiriki/src/scores.h 1117862 
>   /trunk/KDE/kdegames/kiriki/src/scores.cpp 1117862 
> 
> Diff: http://reviewboard.kde.org/r/3793/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luiz Romário
> 
>



More information about the kde-games-devel mailing list