[Kde-games-devel] Review Request: Hint in Kiriki

[Luiz Romário Santana Rios]

> On None, Parker Coates wrote:
> > /trunk/KDE/kdegames/kiriki/src/scores.cpp, lines 63-78
> > <http://reviewboard.kde.org/r/3793/diff/1/?file=24416#file24416line63>
> >
> >     It's a matter of style, but doing assignment in the parameter of a function call is kind of weird and not terribly readable.
> >     
> >     Personally, I would make m_playerNames a const member and do the following in the initialisation list, then just use m_playnames directly when creating the Rows. Or maybe static const would be even better, but it doesn't really matter as there's only one scores object.
> >     
> >     scores::scores()
> >       : m_playNames({i18n("1s"),
> >                      i18n("2s"),
> >                      ...
> >                      i18n("Chance")})
> >

warning: extended initializer lists only available with -std=c++0x or -std=gnu++0x

So, I'd have to assign one by one anyway.

m_playNames[0] = i18n("1s");
// ...


- Luiz Romário


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3793/#review5218
-----------------------------------------------------------


On 2010-04-26 04:24:11, Luiz Romário Santana Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3793/
> -----------------------------------------------------------
> 
> (Updated 2010-04-26 04:24:11)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch implements hint in Kiriki, using the computer itself to give it. The tips are shown in the status bar - that is hidden right after the roll.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.h 1118848 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1118848 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.h 1118848 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp 1118848 
>   /trunk/KDE/kdegames/kiriki/src/scores.h 1118848 
>   /trunk/KDE/kdegames/kiriki/src/scores.cpp 1118848 
> 
> Diff: http://reviewboard.kde.org/r/3793/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luiz Romário
> 
>