[Kde-games-devel] Review Request: KScoreDialog with level selection

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1743/#review2528
-----------------------------------------------------------



trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h
<http://reviewboard.kde.org/r/1743/#comment1858>

    Do you really think it's good that setLevelName calls addLocalizedLevelName? For me "Set" only "sets" not "setsAndAdds", so if you do it, you can either remove it (if i convince you) or add it to the documentation so people like me knows what is happening


- Albert


On 2009-10-02 10:46:10, Felix Lemke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1743/
> -----------------------------------------------------------
> 
> (Updated 2009-10-02 10:46:10)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Hi,
> 
> in KSpiral I need a different height-score for each level. For this I've patched the KScoreDialog. I've tested the KScoreDialog in different games (like kdiamond, kbounce, knetwalk) and I think it's fully backwards compatible. Now there are three new functions:
>  - addLocalizedLevelName(QPair<QByteArray, QString> level): with this you can add an level to the dialog. If the list of level isn't empty above the tabwidget is a QComboBox shown, where you can choose the level.
> 
>  - addLocalizedLevelNames(QMap<QByteArray, QString> level): nearly the same like the function above, but you can add more than one level at once.
> 
>  - setLevelName: to read or write the config belonging to your level you need to set the current level name. In the rc-file of your application the groupname is changed from KHightScore_GameDifficulty to KHighScore_GameDifficulty_MAP:levelname.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1029697 
>   trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1029697 
> 
> Diff: http://reviewboard.kde.org/r/1743/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> new KScoreDialog with level selection
>   http://reviewboard.kde.org/r/1743/s/214/
> 
> 
> Thanks,
> 
> Felix
> 
>