[Kde-games-devel] Review Request: KScoreDialog with level selection

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1743/#review2522
-----------------------------------------------------------


On Fri, Oct 2, 2009 at 03:22, Dmitry Suzdalev wrote:
> Actually I'm not sure if this really should be added to KScoreDialog.
>
> It seems to me that if every game which has a slightly different layout of its
> highscore system would patch libkdegames, we would end up with a mess in API
> and in implementation.
>
> What do others think?
>
> And also is this  change absolutely needed to be in KScoreDialog and why?

Tsk, tsk, Dmitry! Review board comments are supposed to stay on the ReviewBoard! :D

As you might remember, a while back Matt Williams and I started work on a replacement for KScoreDialog. The idea was to split the implementation into a score loading, saving, sorting, etc. backend (KScoreManager) which would be flexible enough to handle several different types of scores. The score GUIs would be provided separately and largely interchangable. Also if a game had very particular needs, it wouldn't be too much effort to write an entirely new GUI for it.

That was the idea. Unfortunately, it quickly died as we both moved on to other things. Matt did most of the work on the original API, and I made a first run at an implementation. Neither are near final, but if I remember correctly, I got it to the point where the functionality roughly matched that of KScoreDialog.

In this highscore utopia we were planning, KScoreDialog would die an slow death in unused obscurity. Unfortunately that utopia never came, so we're force to find a practical solution. Personally, I don't this patch is a great solution, but I can't really think of a better way to implement this into KScoreDialog.

What do you think KSpiral should do instead?

- Parker


On 2009-10-02 10:46:10, Felix Lemke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1743/
> -----------------------------------------------------------
> 
> (Updated 2009-10-02 10:46:10)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Hi,
> 
> in KSpiral I need a different height-score for each level. For this I've patched the KScoreDialog. I've tested the KScoreDialog in different games (like kdiamond, kbounce, knetwalk) and I think it's fully backwards compatible. Now there are three new functions:
>  - addLocalizedLevelName(QPair<QByteArray, QString> level): with this you can add an level to the dialog. If the list of level isn't empty above the tabwidget is a QComboBox shown, where you can choose the level.
> 
>  - addLocalizedLevelNames(QMap<QByteArray, QString> level): nearly the same like the function above, but you can add more than one level at once.
> 
>  - setLevelName: to read or write the config belonging to your level you need to set the current level name. In the rc-file of your application the groupname is changed from KHightScore_GameDifficulty to KHighScore_GameDifficulty_MAP:levelname.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1029697 
>   trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1029697 
> 
> Diff: http://reviewboard.kde.org/r/1743/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> new KScoreDialog with level selection
>   http://reviewboard.kde.org/r/1743/s/214/
> 
> 
> Thanks,
> 
> Felix
> 
>