[Kde-games-devel] Review Request: KScoreDialog with level selection

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1743/#review2516
-----------------------------------------------------------



trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h
<http://reviewboard.kde.org/r/1743/#comment1843>

    levelnames -> level names
    Here and in more places



trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h
<http://reviewboard.kde.org/r/1743/#comment1844>

    add -> adds
    Here and in more places



trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h
<http://reviewboard.kde.org/r/1743/#comment1845>

    The example is wrong, ki18n does not return a QString



trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h
<http://reviewboard.kde.org/r/1743/#comment1847>

    What do you need the translated name for here?



trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp
<http://reviewboard.kde.org/r/1743/#comment1848>

    KComboBox



trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp
<http://reviewboard.kde.org/r/1743/#comment1849>

    This is quite innefficient, i know the other functions are coded the same way, but could you do it the proper way, that is using an iterator?


- Albert


On 2009-10-01 13:08:20, Felix Lemke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1743/
> -----------------------------------------------------------
> 
> (Updated 2009-10-01 13:08:20)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Hi,
> 
> in KSpiral I need a different height-score for each level. For this I've patched the KScoreDialog. I've tested the KScoreDialog in different games (like kdiamond, kbounce, knetwalk) and I think it's fully backwards compatible. Now there are three new functions:
>  - addLocalizedLevelName(QPair<QByteArray, QString> level): with this you can add an level to the dialog. If the list of level isn't empty above the tabwidget is a QComboBox shown, where you can choose the level.
> 
>  - addLocalizedLevelNames(QMap<QByteArray, QString> level): nearly the same like the function above, but you can add more than one level at once.
> 
>  - setLevelName: to read or write the config belonging to your level you need to set the current level name. In the rc-file of your application the groupname is changed from KHightScore_GameDifficulty to KHighScore_GameDifficulty_MAP:levelname.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1029697 
>   trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1029697 
> 
> Diff: http://reviewboard.kde.org/r/1743/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> new KScoreDialog with level selection
>   http://reviewboard.kde.org/r/1743/s/214/
> 
> 
> Thanks,
> 
> Felix
> 
>