[Kde-games-devel] Review Request: KScoreDialog with level selection

[Felix Lemke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1743/
-----------------------------------------------------------

(Updated 2009-10-01 13:08:20.394888)


Review request for KDE Games.


Changes
-------

The edit->setFocus()-call has absolutly no effect, because it's called before the dialog is shown. It worked in the past, because the KLineEdit was the only input method in this dialog. But now there is the QComboBox too, so I reimplemented the showEvent().

Another fix is, that the ComboBox selects the element choosen with setLevelName().


Summary
-------

Hi,

in KSpiral I need a different height-score for each level. For this I've patched the KScoreDialog. I've tested the KScoreDialog in different games (like kdiamond, kbounce, knetwalk) and I think it's fully backwards compatible. Now there are three new functions:
 - addLocalizedLevelName(QPair<QByteArray, QString> level): with this you can add an level to the dialog. If the list of level isn't empty above the tabwidget is a QComboBox shown, where you can choose the level.

 - addLocalizedLevelNames(QMap<QByteArray, QString> level): nearly the same like the function above, but you can add more than one level at once.

 - setLevelName: to read or write the config belonging to your level you need to set the current level name. In the rc-file of your application the groupname is changed from KHightScore_GameDifficulty to KHighScore_GameDifficulty_MAP:levelname.


Diffs (updated)
-----

  trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1029697 
  trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1029697 

Diff: http://reviewboard.kde.org/r/1743/diff


Testing
-------


Screenshots
-----------

new KScoreDialog with level selection
  http://reviewboard.kde.org/r/1743/s/214/


Thanks,

Felix