[Kde-games-devel] Review Request: Adapt KGamePopupItem to Qt 4.5 and 4.6 improvements

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2296/#review3335
-----------------------------------------------------------



/trunk/KDE/kdegames/libkdegames/kgamepopupitem.cpp
<http://reviewboard.kde.org/r/2296/#comment2650>

    No, I don't think so. KPat doesn't use KGamePopupItem, but it has Z values above 1000. Whatever value is picked will be arbitrary, but I would go with something more obviously "big", like 1e6.



/trunk/KDE/kdegames/libkdegames/kgamepopupitem.cpp
<http://reviewboard.kde.org/r/2296/#comment2651>

    Is a state machine really needed? I could be wrong, but this seems like overkill for an animation with only states. Why not use just a single QParallelAnimationGroup?



/trunk/KDE/kdegames/libkdegames/kgamepopupitem_p.h
<http://reviewboard.kde.org/r/2296/#comment2654>

    Is creating three private QGI subclasses really that much simpler then just doing everything in a single paint() method?
    
    I don't really understand what KGamePopupGraphicsObject is even needed for. Could you explain this a bit?
    
    



/trunk/KDE/kdegames/libkdegames/kgamepopupitem_p.h
<http://reviewboard.kde.org/r/2296/#comment2653>

    Putting all this code in a header will force it to be inlined, right? Is that really what you want?


- Parker


On 2009-11-28 19:44:51, Stefan Majewsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2296/
> -----------------------------------------------------------
> 
> (Updated 2009-11-28 19:44:51)
> 
> 
> Review request for KDE Games and Dmitry Suzdalev.
> 
> 
> Summary
> -------
> 
> Apart from some general cleanup, the most interesting changes are:
> * Use QGraphicsItem::opacity. (KGamePopupItem::messageOpacity is deprecated now.)
> * Use QGraphicsPathItem and QGraphicsPixmapItem instead of painting primitives.
> * Improve event handling of the QGraphicsTextItem.
> * Radically simplify internal layouting code.
> * Instead of QTimeLine, animations are now implemented as QPropertyAnimations and orchestrated by a QStateMachine.
> 
> Note that the changes are rather extensive. (I estimate that 80% of the codebase has already changed, and I'm not finished yet.) If you prefer that, I can also send you 12 separate patches of the single commits I made in my git-svn repository.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/libkdegames/kgamepopupitem.h 1054906 
>   /trunk/KDE/kdegames/libkdegames/kgamepopupitem.cpp 1054906 
>   /trunk/KDE/kdegames/libkdegames/kgamepopupitem_p.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/2296/diff
> 
> 
> Testing
> -------
> 
> I have used kgamepopupitemtest to keep regressions at a minimum. I'm aware of and investigating the issue that hiding is not animated.
> 
> 
> Thanks,
> 
> Stefan
> 
>