[Kde-games-devel] Palapeli: a belated review

[Matthew Woehlke]

Stefan Majewsky wrote:
> Am Freitag 06 November 2009 10:38:35 schrieb Ian Wadham:
>> I see that the RMB now moves the view, so I would suggest
>> removing the LMB move of the view, maybe with a popup to say
>> to use the RMB.  Also I would suggest a  more "positive" mouse
>> pointer than the hand.
> 
> I'm with Matthew here. LMB is the default behavior provided by many 
> applications, although Matthew is right that "if there is a way to make [piece 
> selection] more forgiving, e.g. grab closest piece within so many pixels, even 
> if you are not actually on the piece, [...] that would be a big help".

So is LMB pan going away? :-)

>> Just a few more minor points:
>>   - Can we change the properties of a puzzle in My Library?  I gave
>>     one of my puzzles the wrong name ...
> 
> I'm not sure about this one. The puzzles in the library could also be imported 
> from some external resource, and it is not a good idea to let the user put his 
> name on puzzles made by others. Perhaps some special rule could be inserted to 
> allow editing only for puzzles created on this computer, but that would 
> require to change the library format. I do not like changing formats some days 
> before release (even if the release is only to kdereview).

Isn't it possible to simply edit 
$KDEHOME/share/config/palapeli-libraryrc directly? So I'm not sure this 
is really a problem; if someone wants to "maliciously" edit a puzzle's 
info they can already do that, but it is inconvenient to fix e.g. typos.

>>   - Could the tab be called "My Collection"?  "Library" is for books and
>>     programs I would say.
>>   - How do you get access to the example puzzles?
> 
> Aren't they installed for you? If not, do a "bash make-puzzles.sh" in the 
> puzzles subdirectory, then "make install" again. (I know, it's awkward. That 
> will change when Palapeli moves to kdereview.)

You might want to regenerate the puzzles after revisiting the seam 
visibility issue. (The pen width needs to be 2.0 to fully eliminate 
seams, not 1.5... though even then I see a small number of glitches at 
corners, but at least it is /only/ corners.)

>>   - Long-term we may need ways to be not so obvious when a fit occurs
>>     and to tear a piece loose if it is in the wrong place.  I've seen
>>  puzzles with that level of difficulty ...
> 
> Currently, you cannot at all affix pieces to other pieces that are not direct 
> neighbors. This is due to the generality of Palapeli's game engine: It does 
> not make any assumptions about how pieces are ordered.

Personally I'm okay with this behavior, even though it /is/ a little odd 
when any piece can fit perfectly with any other piece (e.g. rectangle 
slicer, but also any tessellating slicer).

Parker Coates wrote:
> I  can't believe that Ian and Matthew would give you a big list of
> complaints for your birthday. Do they have no sense of decency? :D

Now, now, they're not complaints, they're constructive suggestions! :-)

> Seriously though, happy birthday!

+1 :-)

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
My preferred shell is Christian. It's Bourne Again.