[Kde-games-devel] Review Request: Konquest: add support for svg-themeable highlights for planet names and ships count

[Parker Coates]

> On 2009-11-07 15:10:49, Parker Coates wrote:
> > trunk/KDE/kdegames/konquest/mapitems.cc, line 140
> > <http://reviewboard.kde.org/r/2086/diff/1/?file=13830#file13830line140>
> >
> >     Is it really worth it abbreviating "bckgrnd"? This is really just a matter personal preference, the name is already quite long. Is saving three vowels really worth the extra effort of trying to remember the correct abbreviation?
> 
> Dmitry Suzdalev wrote:
>     Hehe. "bkgnd", not "bckgrnd" - two chars less. but anyway, can change this - no probs. This is just abbreviation i get used to...

Well, if anything I guess that proves that arbitrary abbreviations are hard to remember. :P

I realise now that I commented on the wrong line. I meant to comment on the name of the SVG ID, because that's semi-public API (artist program interface). I couldn't care less about the name of the internal variable. :)


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2086/#review2970
-----------------------------------------------------------


On 2009-11-06 16:23:37, Dmitry Suzdalev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2086/
> -----------------------------------------------------------
> 
> (Updated 2009-11-06 16:23:37)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Implemented an Eugene's (it-s) request:
> 
> For proper themeing he needs the way to "highlight" the planet names and ships count texts that are drawn near each planet.
> This is needed because otherwise they are always drawn in black text and this doesn't correlate well with some backgrounds.
> We communicated that it would be great for our artists to have two additional svg elements which will be drawn under the texts, 
> so they can presizely control highlights.
> 
> So that's what i've done - i've added a support for two svg elements with IDs "planet_name_bkgnd" and "planet_ship_count_bkgnd" and made 
> them to be rendered under the respective texts.
> 
> Along with this change i did some minor things:
> - Stored some often used values in variables - instead of calling functions and evaluating same expressions every time
> - Fixed a typo which might prevented caching to work properly - QString+int won't work :) it has to be QString+QString::number(int).
> - Replaced painting custom pixmap and setting it as alfamask with simpler pix.fill(Qt::transparent)
> - Do not use hardcoded font heights/widths - calculate them with QFontMetrics
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/konquest/mapitems.cc 1045668 
>   trunk/KDE/kdegames/konquest/pics/default_theme.svgz UNKNOWN 
> 
> Diff: http://reviewboard.kde.org/r/2086/diff
> 
> 
> Testing
> -------
> 
> Tested rendering. Looks ok.
> 
> 
> Thanks,
> 
> Dmitry
> 
>