[Kde-games-devel] Review Request: Fix Qt-4.6 regressions in Konquest

[Pierre]

On Thursday 05 November 2009 16:47:28 Dmitry Suzdalev wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2079/
> -----------------------------------------------------------
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch fixes the following regressions which I discovered when running
>  Konquest with 4.6:
> 
> 1. Calling QGS::width() or QGS::height() from some
>  QGraphicsItem::boundingRect() reimplementation will cause an endless loop.
>  This happens because QGS::width() calls QGS::itemsBoundingRect() which
>  again calls QGraphicsItem::boudnignRect() => voila :) Solution: cache
>  scene width and height in local variables.
I think you broke resizing of the window… I'm gonna check.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20091105/0063f5d3/attachment.sig