[Kde-games-devel] Review Request: Makes the status text in KGoldrunner easier to translate properly

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/754/
-----------------------------------------------------------

(Updated 2009-05-23 11:54:29.369656)


Review request for KDE Games.


Changes
-------

Now pauseKeys is no longer a QList<QKeySequence> but a QStringList filled in a foreach loop over QAction::shortcuts().
This way the conversion to String is only made in one place (shorter statements elsewhere)

Additionally the pauseKeys is no longer a member. The assignment in optionsConfigureKeys() is gone since gameFreeze is calles there anyway and retrieves the current keys.

I consider this the final version of this patch. ;)
The tests are as said for the first patch. All these things work here.


Summary
-------

Makes the status text easier to translate properly.


Diffs (updated)
-----

  /trunk/KDE/kdegames/kgoldrunner/src/kgoldrunner.h 970906 
  /trunk/KDE/kdegames/kgoldrunner/src/kgoldrunner.cpp 970906 

Diff: http://reviewboard.kde.org/r/754/diff


Testing
-------

- text toggles correctly when one of the keys is pressed
- text changes correctly when the shortcuts are edited
- translation works fine (did the gettext foo locally)
- checked that the universe did not collapse so far


Thanks,

Frederik