[Kde-games-devel] Hardcoded Quotation in KGoldrunner

[Albert Astals Cid]

A Dissabte, 23 de maig de 2009, Ian Wadham va escriure:
> On Sat, 23 May 2009 8:38:09 pm Albert Astals Cid wrote:
> > A Dissabte, 23 de maig de 2009, Ian Wadham va escriure:
> > > Some light is falling upon this issue now.
> > >
> > > On Fri, 22 May 2009 6:49:03 am Albert Astals Cid wrote:
> > > > A Dijous, 21 de maig de 2009, Frederik Schwarzer va escriure:
> > > > > There is some oddness of the following code in src/kgoldrunner.cpp
> > > > >
> > > > >  887     // Now update the PAUSE/RESUME message in the status bar.
> > > > >  888     kDebug() << "Update Pause/Resume message ...";
> > > > >  889     pauseKeys =
> > > > >             
> > > > > myPause->shortcut().toString(QKeySequence::NativeText); 890    
> > > > > pauseKeys = pauseKeys.replace (';', "\" " + i18n ("or") + " \"");
> > > > > 891     gameFreeze (frozen);»···»···// Refresh the status bar text.
> > > > >
> > > > > The string translators see is
> > > > >     Press \"%1\" to PAUSE
> > > > >
> > > > > In German this is translated as
> > > > >     Drücken Sie „%1“, um eine Pause zu machen
> > > > >
> > > > > Together with the above code, it looks like this in KDE 4.2:
> > > > >     Drücken Sie „P" oder " ESC“, um eine Pause zu machen
>
> OK, I have just committed a fix to restore the 2 keystroke or 1 keystroke
> version of the message, as it was in KDE 4.2 and earlier.  I have also
> fixed Albert's issues of July 2008:
>
>  - Using the QKeySequence::NativeText option to get key-sequence strings,
>  - Updating the status bar message whenever the user changes key settings.
>  - Showing the user's latest choice of keys when the games starts.
>
> Albert, I do not know how to test the first item nor am I sure what to look
> for, so please could you check that the QKeySequence::NativeText thing
> is operating as you expect (in Spanish)?
>
> > > That "odd" code has been in KGoldrunner for about 5.5 years and
> > > was first released in KDE 3.2.  It is now nearing the end of its
> > > working life and will be gone whenever I can finish replacing the
> > > status bar with graphical objects (e.g. in KDE 4.4 now), so I do not
> > > propose to break string freeze by re-writing the code at this late
> > > stage.
> >
> > Well, it actually fixes a problem with i18n in the german language i
> > don't really see a problem in fixing it, after all we are doing such
> > "break freeze to improve" commits quite a lot since "real" 4.3 release is
> > still far away.
>
> Errmmm ... the operative phrase, for me, was "at this late stage".  I have
> other priorities now.  I have just done a major review and update of the
> KGoldrunner Handbook, in time for the doco freeze on Tuesday.  Also,
> KGoldrunner has been extensively re-written and I have weeks of
> in-depth testing, bug-fixing, etc. yet to do.  That must take priority.
>
> If anyone else would like to fix the hardcoded quotes, there are *two*
> places where they occur, in KGoldrunner::initStatusBar() and in
> KGoldrunner::optionsConfigureKeys() and there will be four
> messages required instead of two in KGoldrunner::gameFreeze(),
> the two messages already there and two more to allow for cases
> with two shortcuts for the Pause/Resume action.

Frederik? Parker?

Albert

>
> Cheers, Ian W.
>
>
>
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel