[Kde-games-devel] Hardcoded Quotation in KGoldrunner

[Albert Astals Cid]

A Dissabte, 23 de maig de 2009, Ian Wadham va escriure:
> Some light is falling upon this issue now.
>
> On Fri, 22 May 2009 6:49:03 am Albert Astals Cid wrote:
> > A Dijous, 21 de maig de 2009, Frederik Schwarzer va escriure:
> > > There is some oddness of the following code in src/kgoldrunner.cpp
> > >
> > >  887     // Now update the PAUSE/RESUME message in the status bar.
> > >  888     kDebug() << "Update Pause/Resume message ...";
> > >  889     pauseKeys =
> > >              myPause->shortcut().toString(QKeySequence::NativeText);
> > >  890     pauseKeys = pauseKeys.replace (';', "\" " + i18n ("or") + "
> > > \""); 891     gameFreeze (frozen);»···»···// Refresh the status bar
> > > text.
> > >
> > > The string translators see is
> > >     Press \"%1\" to PAUSE
> > >
> > > In German this is translated as
> > >     Drücken Sie „%1“, um eine Pause zu machen
> > >
> > > Together with the above code, it looks like this in KDE 4.2:
> > >     Drücken Sie „P" oder " ESC“, um eine Pause zu machen
>
> That "odd" code has been in KGoldrunner for about 5.5 years and
> was first released in KDE 3.2.  It is now nearing the end of its
> working life and will be gone whenever I can finish replacing the
> status bar with graphical objects (e.g. in KDE 4.4 now), so I do not
> propose to break string freeze by re-writing the code at this late stage.

Well, it actually fixes a problem with i18n in the german language i don't 
really see a problem in fixing it, after all we are doing such "break freeze 
to improve" commits quite a lot since "real" 4.3 release is still far away.

Albert