[Kde-games-devel] Review Request: Kapman: Score information makes Game Area smaller

[Omer F. USTA]

> On 2009-05-06 06:04:22, Alexander Smirnov wrote:
> > As for "after patch" screenshot: I think values on a separate line do not look pretty.
> > As for the code: if possible, try to get rid of magic numbers 2,5,8

Could you please review the newer version of my patch ?
at ->  http://reviewboard.kde.org/r/702

Now it is not in game area and imho it looks much better.


- Omer F.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/659/#review1074
-----------------------------------------------------------


On 2009-05-03 10:20:21, Omer F. USTA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/659/
> -----------------------------------------------------------
> 
> (Updated 2009-05-03 10:20:21)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Score , Level and Life information was at the bottom of the game.
> These informations are making game area smaller after they added to
> screen.
> I have moved these values to unused right screen area thanks to this
> now after game starts svg graphics won't resize and makes game smaller
> and it looks much prettier.
> I think screen shots will explain it better than my explanation 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kapman/gamescene.cpp 962958 
> 
> Diff: http://reviewboard.kde.org/r/659/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Before Patch - Begining
>   http://reviewboard.kde.org/r/659/s/113/
> Before Patch - While Playing
>   http://reviewboard.kde.org/r/659/s/114/
> After Patch
>   http://reviewboard.kde.org/r/659/s/115/
> 
> 
> Thanks,
> 
> Omer F.
> 
>