[Kde-games-devel] Review Request: Kapman: Score information makes Game Area smaller
Alexander Smirnov
alexander.smirnoff at gmail.com
Wed May 6 15:04:15 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/659/#review1074
-----------------------------------------------------------
As for "after patch" screenshot: I think values on a separate line do not look pretty.
As for the code: if possible, try to get rid of magic numbers 2,5,8
- Alexander
On 2009-05-03 10:20:21, Omer F. USTA wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/659/
> -----------------------------------------------------------
>
> (Updated 2009-05-03 10:20:21)
>
>
> Review request for KDE Games.
>
>
> Summary
> -------
>
> Score , Level and Life information was at the bottom of the game.
> These informations are making game area smaller after they added to
> screen.
> I have moved these values to unused right screen area thanks to this
> now after game starts svg graphics won't resize and makes game smaller
> and it looks much prettier.
> I think screen shots will explain it better than my explanation
>
>
> Diffs
> -----
>
> trunk/KDE/kdegames/kapman/gamescene.cpp 962958
>
> Diff: http://reviewboard.kde.org/r/659/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Before Patch - Begining
> http://reviewboard.kde.org/r/659/s/113/
> Before Patch - While Playing
> http://reviewboard.kde.org/r/659/s/114/
> After Patch
> http://reviewboard.kde.org/r/659/s/115/
>
>
> Thanks,
>
> Omer F.
>
>
More information about the kde-games-devel
mailing list