[Kde-games-devel] Review Request: KMines: fix the problem, where the too early starting timer can result in revealing a mine on the first click

[Dmitry Suzdalev]

For some strange bug in reviewboard it won't let me comment although I did 
login correctly :)

Patch looks good and yes, I thought Clemens would commit it.

If you have some time, please commit, Albert - or I'll do this tomorrow.

Cheers, 
Dmitry.

On Friday 15 May 2009 01:41:20 Albert Astals Cid wrote:
> > On 2009-02-23 01:12:52, Dmitry Suzdalev wrote:
> > > Looks ok to me, thanks!
> >
> > Albert Astals Cid wrote:
> >     has this been commited?
> >
> > Clemens Werther wrote:
> >     No
> >
> > Albert Astals Cid wrote:
> >     And why wasn't it commited if Dmitry said "Ship it!"?
> >
> > Clemens Werther wrote:
> >     I have no clue why it wasn't committed.
>
> ECommunicationFailure
>
> When Dimitry said "Ship it!" he was expecting you to commit it :-), the
> problem is that you don't have an account so you can't commit it. Dimitry,
> do we still want to commit this? Do you do it or do i?
>
>
> - Albert
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/158/#review241
> -----------------------------------------------------------
>
> On 2009-05-13 13:01:14, Clemens Werther wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/158/
> > -----------------------------------------------------------
> >
> > (Updated 2009-05-13 13:01:14)
> >
> >
> > Review request for KDE Games.
> >
> >
> > Summary
> > -------
> >
> > Change 1 and 5:
> > This puts the "first-click-detection" routine where it belongs.
> >
> > Change 2:
> > press left; press mid; release left; move mouse over another cell; press
> > left; release mid; release left
> >
> > Without the change, the timer would start, although no item is revealed
> > (only really visible after applying change 1 and 5, because without, the
> > timer even starts when any mouse button is down... ).
> >
> > Change 3 and 4:
> > press left; press mid; release left; release mid
> >
> > Without the change, this would result in a pressed item, although the
> > mouse is not pressed anymore.
> >
> >
> > After applying the whole patch, situations like the one in the screenshot
> > shouldn't be possible anymore.
> >
> >
> > Diffs
> > -----
> >
> >   trunk/KDE/kdegames/kmines/minefielditem.cpp 925889
> >
> > Diff: http://reviewboard.kde.org/r/158/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Screenshots
> > -----------
> >
> > fail at first click
> >   http://reviewboard.kde.org/r/158/s/29/
> >
> >
> > Thanks,
> >
> > Clemens