[Kde-games-devel] Review Request: KMines: fix the problem, where the too early starting timer can result in revealing a mine on the first click
Clemens Werther
cl3m3ns at googlemail.com
Wed May 13 21:32:34 CEST 2009
> On 2009-02-23 01:12:52, Dmitry Suzdalev wrote:
> > Looks ok to me, thanks!
>
> Albert Astals Cid wrote:
> has this been commited?
No
- Clemens
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/158/#review241
-----------------------------------------------------------
On 2009-02-22 15:15:51, Clemens Werther wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/158/
> -----------------------------------------------------------
>
> (Updated 2009-02-22 15:15:51)
>
>
> Review request for KDE Games.
>
>
> Summary
> -------
>
> Change 1 and 5:
> This puts the "first-click-detection" routine where it belongs.
>
> Change 2:
> press left; press mid; release left; move mouse over another cell; press left; release mid; release left
>
> Without the change, the timer would start, although no item is revealed (only really visible after applying change 1 and 5, because without, the timer even starts when any mouse button is down... ).
>
> Change 3 and 4:
> press left; press mid; release left; release mid
>
> Without the change, this would result in a pressed item, although the mouse is not pressed anymore.
>
>
> After applying the whole patch, situations like the one in the screenshot shouldn't be possible anymore.
>
>
> Diffs
> -----
>
> trunk/KDE/kdegames/kmines/minefielditem.cpp 925889
>
> Diff: http://reviewboard.kde.org/r/158/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> fail at first click
> http://reviewboard.kde.org/r/158/s/29/
>
>
> Thanks,
>
> Clemens
>
>
More information about the kde-games-devel
mailing list