[Kde-games-devel] Review Request: Kapman: Various trivial patches

[Alexander Smirnov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/657/#review1075
-----------------------------------------------------------

Ship it!


looks fine
"static const " members can be initialized right in place of declaration, so it's ok to write
class Ghost
{
...
static const int POINTS = 200;
...
}

- Alexander


On 2009-05-02 18:57:41, Omer F. USTA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/657/
> -----------------------------------------------------------
> 
> (Updated 2009-05-02 18:57:41)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> pill.cpp/.h :
>   + Change to Proper values instead a hardcoded values
> 
> kapmanparser.cpp/.h :
>   + some of if statements converted to else if statements
> 
> kapmanmainwindow.cpp/.h :
>   + gameview.h double included (one of them in .cpp, another in .h )
> 
> ghost.cpp/.h :
>   + Ghost::POINTS const int value added and make it equals to 200
>   + Change to Proper values instead a hardcoded values
> 
> cell.cpp/.h :
>   + 2 Forgetten const functions for getter func.
> 
> game.cpp/.h :
>   + Forgetten const functions for getter func.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kapman/pill.cpp 962714 
>   trunk/KDE/kdegames/kapman/kapmanparser.cpp 962714 
>   trunk/KDE/kdegames/kapman/kapmanmainwindow.cpp 962714 
>   trunk/KDE/kdegames/kapman/ghost.cpp 962714 
>   trunk/KDE/kdegames/kapman/ghost.h 962714 
>   trunk/KDE/kdegames/kapman/game.cpp 962714 
>   trunk/KDE/kdegames/kapman/game.h 962714 
>   trunk/KDE/kdegames/kapman/cell.cpp 962714 
>   trunk/KDE/kdegames/kapman/cell.h 962714 
> 
> Diff: http://reviewboard.kde.org/r/657/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Omer F.
> 
>