[Kde-games-devel] Review Request: Kpat: Redeal disabled after redealPossible(false) emitted

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/346/#review545
-----------------------------------------------------------

Ship it!


It looks good to me. Do you have commit access to SVN, or do you need someone to commit it for you?

- Parker


On 2009-03-16 14:49:11, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/346/
> -----------------------------------------------------------
> 
> (Updated 2009-03-16 14:49:11)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> My patch fixes the mentioned bug. It also leads to "Hint" and "Demo" being disabled when no moves are possible anymore.
> 
> I hope that this adds no regression (don't think though), as I'm not sure why all the connects were in setScene initially instead of setupActions.
> 
> Please only answer on rb, as I'm not following the kdegames ml.
> 
> 
> This addresses bug 185439.
>     https://bugs.kde.org/show_bug.cgi?id=185439
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kpat/view.cpp 940198 
> 
> Diff: http://reviewboard.kde.org/r/346/diff
> 
> 
> Testing
> -------
> 
> Tested a little bit on 4.2 branch and trunk.
> 
> 
> Thanks,
> 
> Matthias
> 
>