[Kde-games-devel] Review Request: Kpat: Redeal disabled after redealPossible(false) emitted

[Parker Coates]

> On 2009-03-16 19:02:38, Parker Coates wrote:
> > This patch (while an improvement) doesn't fix the bug mentioned nor does it do the other things mentioned. I'm guessing that you forget to include some other files in the diff.
> 
> Matthias Fuchs wrote:
>     Well that is weird as it does here. Just retested it, I even deleted the build-directory of kpat. And no, these small changes were enough to do so.
> 
> Parker Coates wrote:
>     Sorry. It seems I have a problem with the build on my dev machine. I'm now not so sure I was testing a properly patched version. I post back when I get things working again and can really test it out.

Okay. The patch does, in fact, do everything advertised and I don't see any regressions. I'd like to have a bit more time to test and a bit more testing from others. But I think it looks fine for inclusion in 4.3 and possibly backporting to 4.2.x.


- Parker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/346/#review505
-----------------------------------------------------------


On 2009-03-16 14:49:11, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/346/
> -----------------------------------------------------------
> 
> (Updated 2009-03-16 14:49:11)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> My patch fixes the mentioned bug. It also leads to "Hint" and "Demo" being disabled when no moves are possible anymore.
> 
> I hope that this adds no regression (don't think though), as I'm not sure why all the connects were in setScene initially instead of setupActions.
> 
> Please only answer on rb, as I'm not following the kdegames ml.
> 
> 
> This addresses bug 185439.
>     https://bugs.kde.org/show_bug.cgi?id=185439
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kpat/view.cpp 940198 
> 
> Diff: http://reviewboard.kde.org/r/346/diff
> 
> 
> Testing
> -------
> 
> Tested a little bit on 4.2 branch and trunk.
> 
> 
> Thanks,
> 
> Matthias
> 
>