[Kde-games-devel] New AI for bovo
Pelladi Gabor
pelladigabor at gmail.com
Mon Mar 16 23:29:55 CET 2009
I don't have an SVN account, so I would like to ask somebody to commit the patch.
I agree, making separate patches for the bugfixes would be nicer. If you think
it would be worth it I will happily make a patch that doesn't contain the really
small changes related to the bugfixes. And after the large AI patch is
committed, I can send two patches for the two bugs.
Gabor
> 2009/3/16 Pelladi Gabor:
>> I improved my patch to use the <choices> element. I also repaired two bugs,
>> present in the original (current SVN) code. One that the starting player did
>> not change after a finished match, only after an interrupted match. The
>> other one is that graphics garbage was left on the screen after starting a
>> new game, now I make sure invalidate() gets called on a new game.
>
> Generally, we recommend not rolling multiple changes into a single
> commit like this. If you fixed those bugs in separate commits, they
> would show up separately in the commit log and provide better
> documentation of the reasons for the changes.
>
> As far as I'm consider your patch is ready to be committed. Do you
> have an SVN account or do you need someone to commit it for you?
>
> Parker
More information about the kde-games-devel
mailing list