[Kde-games-devel] Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.

Jaime Torres jtamate at gmail.com
Fri Jul 31 21:11:52 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/947/
-----------------------------------------------------------

(Updated 2009-07-31 19:11:52.407426)


Review request for KDE Games and usability.


Changes
-------

Removed a tiny memory leak (in the QStackWidget).
Added two spaces.
Removed the label stuff in the forget slot (it is painted in the aboutToShow).


Summary
-------

Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel.


Diffs (updated)
-----

  /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1003061 
  /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1003061 

Diff: http://reviewboard.kde.org/r/947/diff


Testing
-------

The dialog works as before.


Thanks,

Jaime



More information about the kde-games-devel mailing list