[Kde-games-devel] Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.

[Jaime Torres]

> On 2009-07-30 21:44:02, Albert Astals Cid wrote:
> > Why delete the lowest highscore on remember?
> > 
> > d->lastHighPosition=i; is missing two spaces
> > 
> > Also i don't understand the "show the previous label" part, can you explain it? Wouldn't you need a loop there to move all them up and not just one?

I delete the lowest highscore on remember (as oposed to do it in addScore) because it is there when you know that the new highscore will be remembered, and it can store only 10 highscores, so the lowest one will dissapear.

Spaces, I will fix them.

"show the previous label"... Probably it is not needed (I think they are repainted in the aboutToShow method). I'll try without this.


- Jaime


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/947/#review1862
-----------------------------------------------------------


On 2009-07-30 18:13:26, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/947/
> -----------------------------------------------------------
> 
> (Updated 2009-07-30 18:13:26)
> 
> 
> Review request for KDE Games and usability.
> 
> 
> Summary
> -------
> 
> Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.h 1003061 
>   /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 1003061 
> 
> Diff: http://reviewboard.kde.org/r/947/diff
> 
> 
> Testing
> -------
> 
> The dialog works as before.
> 
> 
> Thanks,
> 
> Jaime
> 
>