[Kde-games-devel] Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.

[Albert Astals Cid]

> On 2009-07-07 09:15:16, Parker Coates wrote:
> > Interesting idea, but as KScoreDialog is currently implemented, clicking the Cancel button doesn't actually forget the score. It just cancels your opportunity to change the name associated with the score.
> 
> Jaime Torres wrote:
>     I've checked again the code (and played a lot to kollision) to check it. 
>     And as I always get the name prompt, when I click on the Forget button, the score is not saved.
>     You can see that the saveScores() method is only called when the Remember button is pressed or when the name prompt is not shown (never happened to me yet).
> 
> Parker Coates wrote:
>     I see now that it depends on how the game makes use of KScoreDialog. In Killbots, for example, where the dialog is reused between showings, canceling does not clear the highscores from the list, so if one new score is cancelled, but following that a score is accepted, then both will be written to the file. Maybe the KScoreDialog should reload the scores from the file everytime Cancel is hit to fix this.

Right, i think Cancel should cancel the highscore entry, Jaime can you include that in your patch?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/947/#review1484
-----------------------------------------------------------


On 2009-07-15 07:23:47, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/947/
> -----------------------------------------------------------
> 
> (Updated 2009-07-15 07:23:47)
> 
> 
> Review request for KDE Games and usability.
> 
> 
> Summary
> -------
> 
> Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 953006 
> 
> Diff: http://reviewboard.kde.org/r/947/diff
> 
> 
> Testing
> -------
> 
> The dialog works as before.
> 
> 
> Thanks,
> 
> Jaime
> 
>