[Kde-games-devel] Review Request: Remember|Forget instead of OK|Cancel in the highscore dialog.

Albert Astals Cid aacid at kde.org
Sun Jul 12 18:10:04 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/947/#review1553
-----------------------------------------------------------


That's because you have only tested Kollision that uses the AskName flag, i think i'd be in favour of your change when the AskName flag is on.

What do you think Parker?

- Albert


On 2009-07-07 08:57:14, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/947/
> -----------------------------------------------------------
> 
> (Updated 2009-07-07 08:57:14)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Use the more descriptive verbs Remember and Forget (this highscore) instead of OK|Cancel.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/libkdegames/highscore/kscoredialog.cpp 953006 
> 
> Diff: http://reviewboard.kde.org/r/947/diff
> 
> 
> Testing
> -------
> 
> The dialog works as before.
> 
> 
> Thanks,
> 
> Jaime
> 
>



More information about the kde-games-devel mailing list